[cmake-developers] Proposal: Using smart pointers to own dynamically allocated memory

[Tushar Maheshwari]

Thanks for the quick response.
I have my commits separated by file groups. I'll open small MRs
collecting the related groups.
Please comment if the grouping is incorrect or if a commit/diff needs
to be moved to a different branch.

Thanks,
Tushar

On Fri, Sep 13, 2019 at 10:46 PM Brad King <brad.king at kitware.com> wrote:
>
> On 9/13/19 12:58 PM, Kyle Edwards via cmake-developers wrote:
> > On Fri, 2019-09-13 at 22:08 +0530, Tushar Maheshwari wrote:
> >> I have pushed some sample commits to
> >> https://gitlab.kitware.com/tusharpm/cmake/commits/smart_mem.
> >>
> >> If this is something I can pursue, I would appreciate a review of my
> >> changes to better suit the project.
> >
> > We have already made lots of progress in replacing manual delete's with
> > std::unique_ptr's, and completing this modernization has been a goal of
> > ours since we switched to C++11. I would very strongly encourage you to
> > open a merge request with any progress you've made in this regard.
>
> Yes.  Your branch changes a lot of areas and there are several other
> rounds of refactoring going on so you may have trouble with conflicts.
> I suggest grouping the changes (e.g. ExportSet) and opening a MR with
> only one area.  Once that is merged open a new MR for another area.
>
> Thanks,
> -Brad