[cmake-developers] Patch: Don't emit warning when config file not found

Brad King brad.king at kitware.com
Mon May 1 10:13:21 EDT 2017


On 04/28/2017 05:43 PM, Christoph Grüninger wrote:
> I attached two patches implementing it.

Good start.  Please reverse the order of the commits to convert to
the nested conditions first.  That will make the logic change in
the second commit easier to follow.

Also please update the test suite.  Some existing tests may need
updates (though I haven't checked).  Also we should add a test for
this use case in `Tests/RunCMake/find_package/RunCMakeTest.cmake`.
The RunCMake infrastructure allows us to check CMake's output.
One can add a test that searches for a DoesNotExist package to
verify the error message.

Please open a merge request for this as `CONTRIBUTING.rst` explains.

Thanks,
-Brad



More information about the cmake-developers mailing list