[cmake-developers] Module macros/function names with single leading underscore

[Jean-Michaël Celerier]

> It's probably going to be an uncommon situation

https://www.google.fr/search?q="macro(_"+site%3A%3Ahttps%3A%2F%2Fgithub.com

A lot are namespaced but skimming a bit through the result, there is also
stuff like *_*INTERNAL_PARSE_FLAGS_ARGS, *_*fixup_target, *_*LSB_RELEASE,
*_*plugin_target_name
which may be at risk for the problem you're exposing.


Best,

-------
Jean-Michaël Celerier
http://www.jcelerier.name

On Tue, Aug 1, 2017 at 10:42 PM, Brad King <brad.king at kitware.com> wrote:

> On 07/23/2017 10:20 AM, Craig Scott wrote:
> > maybe it's worth considering renaming these single underscore
> > internal macros and functions?
>
> Projects that rely on the undocumented feature depend on being
> able to call the original function by prepending the single
> underscore.  We can't change the renaming convention without
> breaking them.  Even a policy for this may be tricky due to
> function definitions being visible globally and therefore
> skipping across policy scopes.
>
> The infinite recursion case you mentioned has long been known
> and may have a few issue tracker entries.  We haven't really
> dealt with it because the feature is undocumented and meant
> for debugging.  If anyone can come up with a compatible fix
> (e.g. explicit diagnostic) that would be great.
>
> Side note: One day I'd like to see a policy that changes
> function/macro definition scopes to be directory-based.
> I haven't thought about the correctness or side-effects of
> that in detail though.
>
> -Brad
> --
>
> Powered by www.kitware.com
>
> Please keep messages on-topic and check the CMake FAQ at:
> http://www.cmake.org/Wiki/CMake_FAQ
>
> Kitware offers various services to support the CMake community. For more
> information on each offering, please visit:
>
> CMake Support: http://cmake.org/cmake/help/support.html
> CMake Consulting: http://cmake.org/cmake/help/consulting.html
> CMake Training Courses: http://cmake.org/cmake/help/training.html
>
> Visit other Kitware open-source projects at http://www.kitware.com/
> opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/cmake-developers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20170803/0c8c6587/attachment.html>