[cmake-developers] [PATCH] Help: Fix cmake-server typo and message type consistency

Brad King brad.king at kitware.com
Fri Oct 21 10:25:19 EDT 2016


On 10/21/2016 09:51 AM, Sylvain Joubert wrote:
> Please find attached a patch that corrects a typo and a inconsistency
> in a code snippet.

Thanks!

BTW, since you last contributed we've switched from using the mailing
list for patches to using GitLab merge requests:

  https://gitlab.kitware.com/cmake/cmake

Please see the updated CONTRIBUTING.rst.

> -This requist will generate build system files in the build directory and
> +This request will generate build system files in the build directory and

Good catch.

> -  {"type":"project"}
> +  {"type":"codemodel"}
...
> -    "inReplyTo":"project",
> +    "inReplyTo":"codemodel",

Tobias, please confirm that this change is correct.

It looks like `"project"` is used in the prose shortly after those hunks.
Should those instances be changed too?

Thanks,
-Brad



More information about the cmake-developers mailing list