[cmake-developers] FastBuild Generator
charles.huet at gmail.com
Mon Oct 10 09:39:21 EDT 2016
I performed all the aforementioned actions, please check everything is OK
I have a few questions:
* the test CMake.CheckSourceTree does not work with Fastbuild, but I could
not get it to work with Ninja either, maybe I have an environment problem ?
* the test SimpleInstall requires trhe build tool to be able to run
multiple instances in the same hierarchy, which Fastbuild does not support.
Should I refactor the test to remove this requirement ? Or simply ignore
the test ?
* It seems SimpleInstall-Stage2 depends upon SimpleInstall, is this right ?
The branch I recently pushed has only a few tests failing, quite a few seem
to be related to a lack of non-source file dependencies as far as I can
Le jeu. 6 oct. 2016 à 19:33, Charles Huet <charles.huet at gmail.com> a écrit :
> >* Please use Utilities/Scripts/clang-format.bash for
> > code style. This is easy to apply automatically later
> > so don't worry about it too much.
> I'll get on this soon, I like to have proper style.
> > * For final integration I'd like the commits to be squashed
> > and arranged in an organized way. This is hard to do until
> > you have everything working though.
> Sure. For now there are the first few commits which I can't change much to
> keep proper attribuation, and a few commits on top which will be squashed
> together once the dev is complete (or maybe earlier if I feel like it).
> >* Please update the license notices to use the new style that
> > we switched to in `master`. Both C++ and .cmake notices
> > changed.
> Will do.
> Le jeu. 6 oct. 2016 à 17:32, Brad King <brad.king at kitware.com> a écrit :
> On 10/06/2016 08:32 AM, Charles Huet wrote:
> > Do you think it is time to start the review, or should it wait
> > until I have 100% of the tests passing ?
> Thanks for the update. Generally my reviews for new features
> mostly look at documentation, tests, style, etc. rather than
> at implementation details (which can easily be fixed/changed
> later). Therefore final review and integration should not start
> until everything is working.
> However, I'm happy to take quick glances at progress once in
> a while. Here are some comments from the current version:
> * Please use Utilities/Scripts/clang-format.bash for
> code style. This is easy to apply automatically later
> so don't worry about it too much.
> * For final integration I'd like the commits to be squashed
> and arranged in an organized way. This is hard to do until
> you have everything working though.
> * Please update the license notices to use the new style that
> we switched to in `master`. Both C++ and .cmake notices
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cmake-developers