[cmake-developers] Contribution for Issue #0015146

Brad King brad.king at kitware.com
Mon Mar 21 10:39:48 EDT 2016


On 03/19/2016 06:56 AM, Sebastian Windisch wrote:
> I like to contribute code for issue #0015146.

Thanks!

> What I did: I introduced a new flag in cmIDEFlagTable.h called
> RegularExpression

Good idea.  That should be able to handle the special parsing
mentioned in my comment in that issue:

 https://cmake.org/Bug/view.php?id=15146#c36772

> {"UACUIAccess", "MANIFESTUAC:level=([a-zA-Z]+) uiAccess=([a-zA-Z]+)$",
> "", "\\2", cmVS7FlagTable::RegularExpression},

This does not look sufficient to match the example given in the
issue description:

 -MANIFESTUAC:"level='requireAdministrator' uiAccess='false'"

IIUC the single quotes are optional as they appear to work when passed
directly on a command line build.  Also I suspect more whitespace
needs to be tolerated.

There are some existing UACExecutionLevel entries in the link flag
tables that were produced by the automated tool we use to generate
the flag tables from MSBuild files originally.  Please check that
they can be removed in favor of your new entries.

Thanks,
-Brad



More information about the cmake-developers mailing list