[cmake-developers] Proposed patch for 0014140: Ninja generator doesn't set version in dylib

[Bruce Stephens]

On Mon, Mar 7, 2016 at 6:06 PM, Brad King <brad.king at kitware.com> wrote:
> On 03/01/2016 04:58 PM, Bruce Stephens wrote:
>> I just copied the relevant code from the Makefiles generator.
>
> Thanks.  Instead of copying, please look at moving the relevant
> methods up to cmCommonTargetGenerator so it can be shared between
> the two generators instead.

Ah, thanks for the class name. I did look for a suitable one but for some reason
didn't spot that one (though the comment makes it obvious that it's suitable).

Moving the method into there worked cleanly.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-OS-X-dylib-versioning-to-Ninja-generator.patch
Type: application/octet-stream
Size: 5618 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20160307/28dbc095/attachment-0001.obj>