[cmake-developers] Dogfooding: clang-tidy, include-what-you-use, link-what-you-use

[Brad King]

On 06/13/2016 10:16 AM, Brad King wrote:
> On 06/12/2016 05:47 PM, Daniel Pfeifer wrote:
>> I have set up a dashboard build where all three mechanisms are enabled:

Thanks.  It looks like you have a Continuous build for this.  That
will be nice in the future but for now it is not useful until the
build is green for `master`.  Please switch back to having an
Experimental build instead while we get the rest of the current
warnings fixed.

FYI, I had to revert your attempt at fixing the stdint.h inclusion
order from `next`:

 cmStandardLexer: #include <cm_kwiml.h>
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=64157fa5

 Revert "cmStandardLexer: #include <cm_kwiml.h>"
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=93627769

Unfortunately the flex-generated output includes several headers
before any content that comes from the input file.  That means
we will have to edit the generated source files to add the
include of cm_kwiml.h (and perhaps cmConfigure.h).  There is
a comment block in the .in files that explains the modifications
we already do to the generated output, so there is precedent
for it.  If you can get the headers added in the right place
I can look at updating the instructions in the comment blocks.

>> Who wants to resolve the link-what-you-use violations?
> 
> Currently that infrastructure hasn't even reached 'master' yet.

The link-what-you-use feature is now in `master`.

-Brad