[cmake-developers] FindFreetype patch for Windows debug lib naming

[Rolf Eike Beer]

Am Freitag, 17. Juni 2016, 13:02:30 schrieb Stuart Mentzer:
> On 6/17/2016 11:54 AM, Brad King wrote:
> On 06/12/2016 01:52 PM, Stuart Mentzer wrote:
> Looking at FindZlib.cmake I think the attached should be OK
> Thanks.  I've applied that as a patch here:
> 
>  FindFreetype: Find release and debug libraries separately
>  https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b213a7f6
> 
> -Brad
> Thanks but a line was lost in translation at the bottom:
> 
> mark_as_advanced(
>   FREETYPE_LIBRARY
>   FREETYPE_INCLUDE_DIR_freetype2
>   FREETYPE_INCLUDE_DIR_ft2build
> )
> 
> SLC handles mark_as_advanced for the _DEBUG and _RELEASE variables but I
> assume we still need the base variable handled in FindFreetype.
> 
> With that fix, if Eike is OK with this then it is done.

No, this is actually correct. The things marked as advanced are cache 
variables. FREETYPE_LIBRARY is computed dynamically. The "advanced" thing is 
to hide these in the default view of cmake-gui.

If Brad says the change of what is cached is ok I'm entirely fine with it.

Eike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20160617/b5301978/attachment.sig>