[cmake-developers] [patch] iOS combined, some fixes

[Ruslan Baratov]

On 15-Jun-16 22:59, Gregor Jasny wrote:
> Hello,
>
> Thanks for the patch!
>
> On 15/06/16 16:41, Ruslan Baratov wrote:
>> Sending some fixes found by testing with Xcode 7.3
> We were chasing some errors regarding the unified build some time ago.
> But it appeared some for of heisenbug: the more I looked the less likely
> it happened.
>
> Is the error 100% reproducible for you?
Yes - for the Travis VM with xcode7.3 image. Not - for my local machine.

>   And do you know what goes wrong?
Yes, I've leaved a note in the comments section. There are some messages 
in error stream, they are not related to lipo location. Here is example 
of the log with error:

    CMake Error at
    /Users/travis/build/ingenue/hunter/_ci/cmake/share/cmake-3.5/Modules/CMakeIOSInstallCombined.cmake:102
    (message):
    Command failed (File name too long): 2016-05-31 18:37:15.058
    xcodebuild[6590:18239] Build settings from command line:
    2016-05-31 18:37:15.059 xcodebuild[6590:18239] TOOLCHAINS =
    com.apple.dt.toolchain.XcodeDefault
    2016-05-31 18:37:15.059 xcodebuild[6590:18239]
    XCODE_DEFAULT_TOOLCHAIN_OVERRIDE =
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo;-info;/Users/travis/build/ingenue/hunter/_testing/Hunter/_Base/7f9eaa4/f53c868/1c14a4b/Build/GTest/Build/GTest-Release-prefix/src/GTest-Release-build/googlemock/Release-iphonesimulator/libgmock.a


>
> Does the
>
>     list(LENGTH _lipo_path len)
>     if(NOT len EQUAL 1)
>
> take paths with spaces into account?
Nope as far as I know. In fact it doesn't catch the error I've seen, I 
decide to add some sanity checks just to be sure.

Ruslo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20160615/e9493d0f/attachment-0001.html>