[cmake-developers] CMake daemon-mode
Brad King
brad.king at kitware.com
Thu Jun 9 13:57:54 EDT 2016
On 06/09/2016 09:27 AM, Brad King wrote:
>> https://github.com/hunger/CMake/commit/bc060a44b6b2c2281ffe99815163ba02ec835dd6
> Good. I need to review that one more deeply but should be able to integrate it.
I split out some incremental commits toward that:
cmCommonTargetGenerator: De-duplicate CMAKE_BUILD_TYPE lookup
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=de4ee088
cmLocalGenerator: Adopt GetFrameworkFlags method
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=70d3bf85
cmLocalGenerator: Move GetFrameworkFlags implementation to private helper
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d9613b96
Please rebase on that (at least once it is in master).
For the main change, please also move over AddFortranFlags, perhaps
becoming cmLocalGenerator::GetFortranFlags. The result should be
that cmCommonTargetGenerator::GetFlags moves into the new
cmLocalGenerator::GetTargetCompileFlags method except for the caching.
That will preserve flag order for GetFlags.
For the Xcode part of the changes, we cannot use the full
GetTargetCompileFlags. The reason is that for Xcode some of the
flags, like the architecture settings, become .pbxproj file properties
instead of raw flags. It may be simplest to just drop that part of
the change for now. Or, we need to factor out an intermediate helper
that can be shared by GetTargetCompileFlags and Xcode.
Thanks,
-Brad
More information about the cmake-developers
mailing list