[cmake-developers] Bug in CMake: Generated Ninja files do not work on Windows

Michael Jäntsch michael.jaentsch at gmx.de
Wed Jun 8 12:49:50 EDT 2016


Hi,

the code looks right to me. Thanks a lot for fixing that so quickly.

Brad is also right about the first byte. The command has the argument
already attached.

Michael

On 06/08/2016 06:46 PM, Brad King wrote:
> On 06/08/2016 12:43 PM, Rolf Eike Beer wrote:
>>>  Run ranlib on archives only if the tool is available
>>>  https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ea598671
>> Shouldn't the first check also be "cmd == ":" instead of only
>> checking the first byte?
> No, because the command in question is actually ": libfoo.a".
> No valid command can start in ":" on any platform.
>
> -Brad
>



More information about the cmake-developers mailing list