[cmake-developers] Topic "add-opencl-imported-target" good to merge?

Brad King brad.king at kitware.com
Wed Jun 1 14:22:29 EDT 2016


On 06/01/2016 02:15 PM, Matthäus G. Chajdas wrote:
> Hopefully done

The revised history looks good.  The change itself looks good.

Please also add a `Help/release/dev/FindOpenCL-imported-target.rst`
file with a release note for the feature.  Look at other files
in that directory for a sample.  See Help/release/*.rst for other
examples.

As part of the modernization of find modules we're also trying
to add better testing for them.  Please see Tests/FindPNG and the
CMake_TEST_FindPNG code path in Tests/CMakeLists.txt and construct
a similar test for the FindOpenCL module.

Thanks,
-Brad



More information about the cmake-developers mailing list