[cmake-developers] [Patch 2/5] Improved WIX support

[Nils Gladitz]

On 21.07.2016 17:32, Brad King wrote:
> On 07/21/2016 10:45 AM, Nils Gladitz wrote:
>> I amended the commit message and added the otherwise missing release note.
> Thanks.  Currently the release note is:
>
>> +* The CPack WIX generator now supports CPACK_COMPONENT_<COMPONENT>_DISABLED.
>> +  This can be used to deselect a component from being installed by default.
> However, that option is not publicly documented as a variable for projects
> to set.  Instead it is the internal representation of the `DISABLED` option
> to `cpack_add_component`.  Please revise the commit message to reference
> this command (as :command:`cpack_add_component`).

 From CPack's point of view the CPACK_* variables are the public interface.
cpack_add_component() (and CPackComponent.cmake) are only involved when 
you use cmake to generate the cpack configuration.

So perhaps the variable should be documented instead?

CPACK_COMPONENT_<COMPONENT>_DISABLED being undocumented might be an 
oversight to begin with given that e.g. 
"CPACK_COMPONENT_<compName>_REQUIRED" is documented (also settable 
through cpack_add_component()).

Nils