[cmake-developers] [PATCH v4 3/4] Use SystemTools::GetEnv and HasEnv functions

Brad King brad.king at kitware.com
Mon Jul 18 10:00:11 EDT 2016


On 07/07/2016 05:54 PM, Dāvis Mosāns wrote:
>  Source/CPack/cmCPackGenerator.cxx           |  8 +++---
>  Source/CTest/cmCTestCoverageHandler.cxx     | 12 ++++-----
>  Source/CTest/cmCTestCurl.cxx                | 27 ++++++++++----------
>  Source/CTest/cmCTestMultiProcessHandler.cxx |  8 +++---
>  Source/cmBuildCommand.cxx                   | 25 +++++++++----------
>  Source/cmCLocaleEnvironmentScope.cxx        |  5 ++--
>  Source/cmCTest.cxx                          | 11 +++++----
>  Source/cmCommandArgumentParserHelper.cxx    |  8 +++---
>  Source/cmConditionEvaluator.cxx             |  2 +-
>  Source/cmExportCommand.cxx                  |  5 ++--
>  Source/cmExtraEclipseCDT4Generator.cxx      |  9 ++++---
>  Source/cmFileCommand.cxx                    | 11 +++++----
>  Source/cmFindPackageCommand.cxx             |  4 +--
>  Source/cmGlobalVisualStudio7Generator.cxx   |  6 ++---
>  Source/cmMakefile.cxx                       |  5 +++-
>  Source/cmNinjaTargetGenerator.cxx           |  2 +-
>  Source/cmQtAutoGenerators.cxx               |  2 +-
>  Source/cmSetCommand.cxx                     |  7 +++---
>  Source/cmState.cxx                          |  5 ++--
>  Source/cmSystemTools.cxx                    |  6 ++---
>  Source/cmTimestamp.cxx                      |  7 +++---
>  Source/cmUtils.hxx                          | 26 ++++++++++++++++++++
>  Source/cmake.cxx                            | 21 +++++-----------
>  Source/cmcmd.cxx                            | 16 +++++-------

Applied:

 Use better KWSys SystemTools::GetEnv and HasEnv signatures
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b1f87a50

>  Source/kwsys/SystemInformation.cxx          | 20 +++++++--------

I dropped this one because it introduces a dependency
SystemInformation => SystemTools that was not there before
and I don't think we need this for the environment variables
it uses.

>  Source/kwsys/SystemTools.cxx                | 38 +++++++++++------------------
>  Source/kwsys/testSystemTools.cxx            |  9 ++++---

Applied to upstream KWSys first:

 http://review.source.kitware.com/21340

Thanks,
-Brad



More information about the cmake-developers mailing list