[cmake-developers] [PATCH] ninja: Generalize check for sysconf(3) call.
Brad King
brad.king at kitware.com
Fri Jul 15 09:52:54 EDT 2016
On 07/15/2016 06:46 AM, Raphael Kubo da Costa wrote:
> Commit f9644a2d ("cmGlobalNinjaGenerator: Clarify logic for forcing use
> of response files") started considering that negative command line
> length values meant forcing the use of response files.
>
> cmNinjaNormalTargetGenerator::calculateCommandLineLength() was not
> implemented for certain operating systems
Thanks. The problem you encountered is actually a regression in 3.6.0.
I've fixed it here:
Ninja: Do not force response files when no sysconf(3) limit is used
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=86dd2427
and queued the change for merge to `release` for 3.6.1.
I've also applied your change on `master` for development toward 3.7:
Ninja: Generalize check for sysconf(3) call
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5ec17e61
Thanks,
-Brad
More information about the cmake-developers
mailing list