[cmake-developers] [PATCH v4 fixed 1/4] On Windows use correct encoding for SystemTools::GetEnv
Dāvis Mosāns
davispuh at gmail.com
Fri Jul 8 09:26:41 EDT 2016
2016-07-08 16:04 GMT+03:00 Brad King <brad.king at kitware.com>:
> On 07/07/2016 06:32 PM, Dāvis Mosāns wrote:
>> On Windows getenv (and putenv) uses ANSI codepage so it needs to be encoded
>> to internally used encoding (eg. UTF-8). Here we use _wgetenv (and _wputenv)
>> instead and encode that.
>>
>> Also add SystemTools::HasEnv function.
>
> Thanks. KWSys is maintained externally to CMake so I've ported
> this patch over for integration there first. I split it into
> two commits for review and testing here:
>
> http://review.source.kitware.com/21318
> http://review.source.kitware.com/21319
>
> Once integrated there I can update it in CMake and then move
> on to more of your patches.
>
Great! Thanks!
More information about the cmake-developers
mailing list