[cmake-developers] [PATCH v3 4/7] For Windows encode process output to internally used encoding

Brad King brad.king at kitware.com
Thu Jul 7 08:44:58 EDT 2016


On 07/06/2016 03:12 PM, Dāvis Mosāns wrote:
> Typically Windows applications (eg. MSVC compiler) use current console's
> codepage for output to pipes so we need to encode that to internally used
> encoding (KWSYS_ENCODING_DEFAULT_CODEPAGE).

We can't do that here.  KWSys Process is a low-level process execution
API and can make no assumptions about the kind of output that comes
from the child.  It might be text or binary, and so cannot be transformed
at this layer in any way.

Higher-level clients within CMake will have to be taught to do the conversion
in cases that the output is expected to be text.  While at it, there was
some discussion a few months ago about newline conversion that needs the
same treatment.

Thanks,
-Brad



More information about the cmake-developers mailing list