[cmake-developers] [PATCH v3 7/7] Add MinGW support for FStream

Mike Gelfand mikedld at mikedld.com
Wed Jul 6 20:51:19 EDT 2016


On 07/07/2016 03:33 AM, Dāvis Mosāns wrote:
> 2016-07-07 1:22 GMT+03:00 Mike Gelfand <mikedld at mikedld.com>:
>>> @@ -92,19 +159,26 @@ namespace @KWSYS_NAMESPACE@
>>> [snip]
>>>    private:
>>>      internal_buffer_type* buf_;
>>> +#if !defined(_MSC_VER)
>>> +    FILE *file_ = 0;
>>> +#endif
>>>  };
>>>
>>>  template<typename CharType,typename Traits = std::char_traits<CharType> >
>> In-place member initialization... As Brad wrote earlier, using C++11 in
>> KWSys is not advised.
>>
> This was already there but only used for _MSC_VER >= 1400
> Maybe could just guard this with  __cplusplus >= 201103L and not support
> Unicode for older, it would be much easier...

Apologies, don't quite get your response. Maybe the quote was too big; I
surely meant to point to "FILE *file_ = 0;" line, not the template
declaration or something else.

Regards,
Mike


More information about the cmake-developers mailing list