[cmake-developers] [patch] One more pattern for extracting file name from URL
Brad King
brad.king at kitware.com
Tue Jul 5 16:26:10 EDT 2016
On 07/05/2016 04:13 PM, Ruslan Baratov wrote:
> Works fine on my tests.
Thanks for testing!
> However I still vote for using default value for 'fname' instead
> of FATAL_ERROR.
I think that behavior would be surprising.
> If something bad will happen user always can use DOWNLOAD_NAME.
>
> Example of the test that will fail with current version but works
> fine with default name:
>
> URL "http://tinyurl.com/jn86pmc"
In that case one can just use DOWNLOAD_NAME. Auto-extraction of
the filename from the URL is a convenience for a common case, but
in principle DOWNLOAD_NAME could always be used.
-Brad
More information about the cmake-developers
mailing list