[cmake-developers] Fix bug in CPack IFW Promoting Updates repository replacement

Konstantin Podsvirov konstantin at podsvirov.pro
Tue Jul 5 16:14:50 EDT 2016


Thanks again, Brad!

05.07.2016, 22:58, "Brad King" <brad.king at kitware.com>:
> On date 07/05/2016 03:39 PM, Konstantin Podsvirov wrote:
>> I found a small bug in CPackIFW. The patch is attached.
>
> Thanks, applied:
>
> CPackIFW: Fix attributes for Promoting Updates repository replacement
> https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7a30fa1a
>
>> Changes are best to send to a mailing list or use your networks?
>
> Either is fine. We're still experimenting with the Networks
> workflow so it is not documented in the CONTRIBUTING.rst yet.

I apologize that sometimes there are persistent, but thank you so much for your feedback and applying my changes.

The theme of integration and CMake QtIFW quite new and deals with both technologies.

I get good feedback from CMake and try to influence the development of QtIFW.

The project QtIFW included in the Qt infrastructure and make changes to it is not so simple. But I'm trying. Here's my first change (it is still pending):

https://codereview.qt-project.org/#/c/163220

I want to go further and to provide CMakeLists.txt to build the QtIFW.
I'm working on this theme in a topic branch "topic-cmake-project" on your server:

http://git.podsvirov.pro/?p=qt/qtifw.git;a=shortlog;h=refs/heads/topic-cmake-project

It is very dirty now, but there are already some results.
The project QtIFW for normal operation requires linking with the static version of the Qt library. This is not standard practice and could have a positive impact on the detection and correction of errors in this case.

I hope that this topic will ever be merged with the project QtIFW.

--
Regards,
Konstantin Podsvirov


More information about the cmake-developers mailing list