[cmake-developers] [patch] One more pattern for extracting file name from URL

[Brad King]

On 07/01/2016 08:01 AM, Ruslan Baratov via cmake-developers wrote:
> With attached patch it's possible to extract name from URLs like 
> 'https://.../archive.tar.gz?a=x&b=y'.

Thanks.

>          elseif(NOT "${fname}" MATCHES "(\\.|=)(7z|tar|tar\\.bz2|tar\\.gz|tar\\.xz|tbz2|tgz|txz|zip)$")
> -          message(FATAL_ERROR "Could not extract tarball filename from url:\n  ${url}")
> +          # Try: https://.../archive.tar.gz?a=x&b=y
> +          string(REGEX MATCH "^.*/([^/]*)\\?.*$" match_result "${url}")
> +          set(fname "${CMAKE_MATCH_1}")
> +          if(NOT "${fname}" MATCHES "(\\.|=)(7z|tar|tar\\.bz2|tar\\.gz|tar\\.xz|tbz2|tgz|txz|zip)$")
> +            message(FATAL_ERROR "Could not extract tarball filename from url:\n  ${url}")
> +          endif()

Please try to structure the logic right in the if/elseif part.
Matching in those also sets `CMAKE_MATCH_*` variables so one
does not need to double-match.

Also, the `([^/]*)\\?.*` part of the regex should be more
like `([^/?]*)\\?.*` to avoid eagerly matching early `?`.

Thanks,
-Brad