[cmake-developers] [PATCH] Fix crash in cmExportInstallFileGenerator::FindNamespaces()

Andrey Pokrovskiy wonder.mice at gmail.com
Wed Jan 20 21:41:21 EST 2016


>From 0852339e3ab545af709246c8e767e996cb629707 Mon Sep 17 00:00:00 2001
From: wonder-mice <wonder.mice at gmail.com>
Date: Wed, 20 Jan 2016 18:29:58 -0800
Subject: [PATCH] Fix crash in cmExportInstallFileGenerator::FindNamespaces()

Found it when was building poco library:
https://github.com/pocoproject/poco.git

Steps to reproduce:
1. Clone poco
2. mkdir poco.git/build.make
3. cd poco.git/build.make
4. cmake ..
5. Crash

As I understand this place was missed during refactoring performed in
this commit:

    commit 381e7afd363d64c72b83e69fd6c6cad5fc3eefb4
    Author: Stephen Kelly <steveire at gmail.com>
    Date:   Sat Oct 17 13:31:33 2015 +0200

    cmExportSet: Store a cmGeneratorTarget.

    Set the member at compute time from the stored name.
---
 Source/cmExportInstallFileGenerator.cxx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Source/cmExportInstallFileGenerator.cxx
b/Source/cmExportInstallFileGenerator.cxx
index b695904..71418e8 100644
--- a/Source/cmExportInstallFileGenerator.cxx
+++ b/Source/cmExportInstallFileGenerator.cxx
@@ -496,7 +496,7 @@ cmExportInstallFileGenerator
     bool containsTarget = false;
     for(unsigned int i=0; i<targets->size(); i++)
       {
-      if (name == (*targets)[i]->Target->GetName())
+      if (name == (*targets)[i]->TargetName)
         {
         containsTarget = true;
         break;
-- 
2.5.4 (Apple Git-61)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-crash-in-cmExportInstallFileGenerator-FindNamesp.patch
Type: application/octet-stream
Size: 1395 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20160120/0d578afa/attachment.obj>


More information about the cmake-developers mailing list