[cmake-developers] [PATCH] FindPNG: Create an imported PNG::PNG target
Stephen Kelly
steveire at gmail.com
Wed Jan 20 15:12:52 EST 2016
rleigh at codelibre.net wrote:
>>> + INTERFACE_LIBRARIES "${PNG_LIBRARIES}")
>>
>> Shouldn't this refer to zlib instead of png libraries again?
>
> I would have expected something like
>
> set_target_properties(PNG::PNG PROPERTIES INTERFACE_LINK_LIBRARIES
> ZLIB::ZLIB)
For reference, this is documented here:
https://cmake.org/cmake/help/v3.4/manual/cmake-packages.7.html#creating-relocatable-packages
but as IMPORTED targets are getting added to find modules now, perhaps the
manual cmake-developer(7) could also get a note about this:
https://cmake.org/cmake/help/v3.4/manual/cmake-developer.7.html#a-sample-find-module
or that section could be extended to generally discuss dependencies.
Thanks,
Steve.
More information about the cmake-developers
mailing list