[cmake-developers] [PATCH 2/2] FindwxWidgets.cmake: Resolve CygWin/MSYS paths to Windows paths

Brad King brad.king at kitware.com
Tue Feb 16 14:17:46 EST 2016


On 02/16/2016 01:42 PM, Greg Jung wrote:
>     A true MinGW wx-config should report Windows paths.
> 
> Good point, which is why modifying wx-config is done. 
>  MSYS/configure ... will build wx as if it knows nothing about 
> windows' paths and the wx-config output works as it should,
> it is an MSYS weakness that fails in one aspect downstream 
> (I forget exactly what), the workaround is to make the paths 
> come out of wx-config in DOS format. Since this workaround
>  wasn't implemented until the more recent msys2 package builds
> (which are compiled with a different compiler - worse possible headaches),
> Simon worked a cmake fix.  For my usage I've been editing wx-config.

Okay, I see that we are already handling this special case in
FindwxWidgets.cmake by using "sh wx-config" in execute_process calls.
This means the module is already aware that the wx-config it is running
is not a Windows tool.  The proposed change merely adds support for
treating the output accordingly.

I've applied the change with minor tweaks and tried to explain this
in the commit message:

 FindwxWidgets: Resolve Cygwin/MSYS paths to Windows paths
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=843213d5

Thanks,
-Brad



More information about the cmake-developers mailing list