[cmake-developers] [PATCH] FindProtobuf: fix wrong library list for Unix

[Brad King]

On 02/08/2016 11:47 AM, Antonio Perez Barrero wrote:
> Avoid looking for debug library unless configuring for MSVC.
[snip]
> -   find_library(${name}_LIBRARY_DEBUG
> -       NAMES ${filename}
> -       PATHS ${PROTOBUF_SRC_ROOT_FOLDER}/vsprojects/${_PROTOBUF_ARCH_DIR}Debug)
> -   mark_as_advanced(${name}_LIBRARY_DEBUG)
> +   if(MSVC)
> +       find_library(${name}_LIBRARY_DEBUG
> +           NAMES ${filename}
> +           PATHS ${PROTOBUF_SRC_ROOT_FOLDER}/vsprojects/${_PROTOBUF_ARCH_DIR}Debug)
> +       mark_as_advanced(${name}_LIBRARY_DEBUG)
> +   endif()

It is possible someone builds a debug-named library on unix too.
See `select_library_configurations` and its uses in other find
modules.  That is the conventional way to normalize libraries
across configurations.

Thanks,
-Brad