[cmake-developers] [PATCH] FindProtobuf: check version

Ben Boeckel ben.boeckel at kitware.com
Mon Feb 8 10:45:34 EST 2016


On Mon, Feb 08, 2016 at 15:29:50 +0000, Antonio Pérez Barrero wrote:
> thanks for feedback, I'll rework the patch. I was planning to actually
> submit three patches covering the following:
> 
> * Version checking
> * Interface variables rename, keeping backwards compatibility.
> * Fix a bug when setting Protobuf_LIBRARIES on Un*x systems.

Looks like a sensible breakdown to me.

> So what's the best way to submit them:
> 
> * A separate format-patch for each.

This one.

Sending it as a series of 3 patches is best (and easy if you use git
send-email). Best is that the earlier patches fix bugs and such so that
if they are OK, they're more easily applied independently if later
patches have issues which need resolving yet.

Thanks,

--Ben


More information about the cmake-developers mailing list