[cmake-developers] install(EXCLUDE_FROM_ALL) new feature - request for comment

Brad King brad.king at kitware.com
Wed Feb 3 14:31:43 EST 2016


On 02/01/2016 05:01 AM, Nick Lewis wrote:
> https://cmake.org/Bug/view.php?id=14921

Thanks.  Actually my request in the issue tracker to post here was meant
to have the actual patch file attached so people can see it without
digging through the messages and attachments there.  Patch revisions
or new patches can be attached in responses within the thread.

Anyway, I've applied the "correction2" patch from the issue tracker,
applied it, and followed up with some test cases.  I merged the topic
to 'next' for testing:

 install: Add EXCLUDE_FROM_ALL option (#14921)
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=0b6c4729

 Tests: Add cases for install() command EXCLUDE_FROM_ALL option
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=670fa897

 Help: Add notes for topic 'install-EXCLUDE_FROM_ALL'
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=cee30e16

but it is not ready for 'master' yet.

Please look at extending the Tests/RunCMake/install test with
cases for more install command signatures.  Please also update
the Help/command/install.rst file documentation to mention the
option in all signatures where it is supported and add a list
entry for it among the main options at the top.

Since I've already applied the original patch, please provide
these updates as new patches that I can apply on top.  Commit
locally in Git and use `git format-patch ...` to produce patch
files to attach here.

Thanks,
-Brad



More information about the cmake-developers mailing list