[cmake-developers] Subject: [PATCH v2] cmFileCommand: Download continuation support

[Brad King]

On 08/18/2016 01:47 PM, Titov Denis wrote:
> +    } else if (*i == "RETRY_COUNT") {
> +      ++i;
> +      if (i != args.end()) {
> +        retryMaxCount = atoi(i->c_str());
> +      } else {
> +        this->SetError("DOWNLOAD missing count for RETRY_COUNT");

Adding tests for these options will be difficult, but we can at least
add tests for the error cases.  Please look at adding cases to

  Tests/RunCMake/file/RunCMakeTest.cmake

for these.  See Tests/RunCMake/README.rst for documentation of how
this test infrastructure works.

Sorry I didn't notice this during my first review.

Thanks,
-Brad