[cmake-developers] [PATCH v7] For Windows encode process output to internally used encoding

Brad King brad.king at kitware.com
Wed Aug 17 09:47:40 EDT 2016


On 08/17/2016 06:11 AM, Dāvis Mosāns wrote:
>> Applied with minor tweaks and merged to `next` for testing:
> 
> Great! Thanks!

I squashed in one warning fix:

 Windows: Encode child process output to internally-used encoding
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=12924660

However, then I had to revert the change from `next` because it
causes the CTest.UpdateGIT test to fail on Windows machines.
I think the problem is that we run Git with a `-z` option to
produce binary output.  In such cases we should not do any
encoding conversions.  cmProcessTools and RunSingleCommand
will need to gain options for this.

Also I noticed that if DecodeText buffers partial characters we
may need a finalize step later to finish them off.  Otherwise
invalid byte sequences may be dropped if they appear at the end.

Please fetch the above version and revise it as needed.

Thanks,
-Brad



More information about the cmake-developers mailing list