[cmake-developers] [PATCH v6] For Windows encode process output to internally used encoding

Brad King brad.king at kitware.com
Mon Aug 15 09:25:44 EDT 2016


On 08/13/2016 08:18 PM, Dāvis Mosāns wrote:
>  Source/ProcessOutput.hxx.in        | 160 +++++++++++++++++++++++++++++++++++++
[snip]
> +      static const UINT defaultCodepage = @KWSYS_ENCODING_DEFAULT_CODEPAGE@;

Thanks.  Overall the approach looks good now.  I'd like to avoid
having to configure this header just for the default codepage value.
Also I'd like to avoid having to include `windows.h` publicly.
Please move the implementation into a .cxx file to hide these
parts away from includers.

Thanks,
-Brad



More information about the cmake-developers mailing list