[cmake-developers] [Patch 5/5] Improved WIX support

[Stuermer, Michael SP/HZA-ZSEP]

> -----Original Message-----
> From: Nils Gladitz [mailto:nilsgladitz at gmail.com]
> Sent: Friday, August 12, 2016 9:42 AM
> To: Stuermer, Michael SP/HZA-ZSEP; CMake Developers
> Subject: Re: [cmake-developers] [Patch 5/5] Improved WIX support
> 
> On 07/20/2016 03:58 PM, Stuermer, Michael SP/HZA-ZSEP wrote:
> 
> > Using the patchfile support I managed to implement the service installation
> issue I had, so the unnecessary features from the last patch are removed
> now.
> >
> > I tested all patches separately and hope they work now.
> >
> > looking forward for feedback,
> >
> > best regrads,
> > Michael
> >
> 
> Patch 5 seems to implement patching of FeatureRef rather than the original
> Feature elements.
> I am not sure if this is what you intended but this could be error prone given
> that there could in theory be any number (0-n) FeatureRef elements for any
> corresponding Feature element.
> 
> Nils

The intention was to be able to add custom components that are added as extra .wxs source files to certain features. If there are more convenient ways to do this I will be happy to change the implementation or adapt my WIX project. But so far this seemed to be a very easy and intuitive solution: the additional component references are added in the same place where all other component references are added as well.

Michael