[cmake-developers] QtAutogen 3.6.0 directory nesting overflow patch

Brad King brad.king at kitware.com
Tue Aug 9 10:11:27 EDT 2016


On 08/08/2016 04:19 PM, Sebastian Holtermann wrote:
> It is back to what it was in 3.5 for the all-qrc-names-unique case.
> So yes, existing projects get the same symbol name they used to get.

Good, thanks.

> New projects that now can use non unique file names
> may get a symbol name based on the checksum extended file name
> - but that one is also length limited and should be safe.

Is this checksum user-facing in that they may need to reference such
a symbol in their own code by this name?  This would restrict us from
ever changing the hash algorithm in the future.

> But I found another issue.
> The checksum string generator may generate a '-' in the file name.
> This is allowed for file names but not for symbol names.
> I have attached a small patch to fix this.

Thanks, I squashed that in.

Why does cmFilePathUuid::GetChecksumString go through so many steps
of transformation?  Why not just take the original hex-valued hash
and use it directly (possibly truncated)?

-Brad



More information about the cmake-developers mailing list