[cmake-developers] [PATCH] Use full path for all source files in ninja build.

[Chaoren Lin]

Thanks. But to address Florent's concern, are there tests that cover the
windows command line limit?
I guess to test if this breaks we'd need a source file whose compile
command is under the limit if using relative path,
but over the limit if using absolute path.

On Mon, Aug 8, 2016 at 11:04 AM, Brad King <brad.king at kitware.com> wrote:

> On 08/08/2016 01:42 PM, Chaoren Lin wrote:
> >> I don't think this hunk is needed anymore, correct?
> >
> > That hunk is the opposite now
>
> Oops, right.  That actually fixes the existing RC bug I mentioned
> earlier in this thread.
>
> With your patch the use of IN_ABS breaks builds with spaces in the
> path.  The reason is that Ninja handles quoting of paths when
> replacing  the `$in` placeholder but does nothing special for
> `$IN_ABS`.  CMake will have to generate the right path in the value.
>
> I've applied the patch with the appropriate modification for that:
>
>  Ninja: Use full path for all source files
>  https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=955c2a63
>
> Thanks,
> -Brad
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20160808/de46c16f/attachment-0001.html>