[cmake-developers] [PATCH] Use full path for all source files in ninja build.
Brad King
brad.king at kitware.com
Mon Aug 8 13:43:12 EDT 2016
On 08/08/2016 09:19 AM, Ben Boeckel wrote:
> On Sun, Aug 07, 2016 at 04:54:52 +0200, Florent Castelli wrote:
>> I'd say that you shouldn't do this unless you have tested it extensively
>> with very long command lines, making sure that there is a response file
>> fallback if it grows too much.
>> There are issues in CMake already on Windows with long command lines and
>> having even longer ones is not going to help.
>
> Agreed. RC files compilation already has issues in some projects without
> absolute paths as is.
>
> https://gitlab.kitware.com/cmake/cmake/issues/16171
RC files used absolute paths prior to this patch. The patch is for
other languages.
Also in out-of-source builds we already use absolute paths to files
in the source tree.
If there are problems with command line lengths they can be addressed
separately.
-Brad
More information about the cmake-developers
mailing list