[cmake-developers] QtAutogen 3.6.0 directory nesting overflow patch

Brad King brad.king at kitware.com
Mon Aug 8 13:40:13 EDT 2016


On 08/06/2016 09:42 AM, Sebastian Holtermann wrote:
> Ok, here is a new set of patches based on the current git master branch.

Thanks!

> +        outStream << "#include \""
> +                  << cmsys::SystemTools::ConvertToOutputPath(it->second)
> +                  << "\"\n";

The ConvertToOutputPath method may also add its own double quotes.
It is not just about slash conversion.  Please use another approach
to convert slashes.  I dropped this patch for now.

Meanwhile I've applied the rest:

 cmFilePathUuid: Add class to generate deterministic unique file names
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ecb6df52

 QtAutogen: Use std:: instead of ::std::
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=06217388

 QtAutogen: Allow multiple moc files with the same name
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3e2cd04b

 QtAutogen: Allow multiple qrc files with the same name
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=71d0308a

 Tests/QtAutogen: Test same moc/qrc source names in different directories
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=20f0028c

and merged to `next` for testing.

One of the problems reported in

  https://gitlab.kitware.com/cmake/cmake/issues/16209

with the previous approach was that the symbol name created by autorcc
changed from what it was in CMake <= 3.5.  Is it now preserved?

Thanks,
-Brad


More information about the cmake-developers mailing list