[cmake-developers] patches from pkgsrc

[Patrick Welche]

On Tue, Aug 02, 2016 at 01:08:23PM -0400, Brad King wrote:
> I've applied the KWSys parts to its upstream:
> 
> * http://review.source.kitware.com/21403 SystemInformation: Treat BSDs more uniformly
> * http://review.source.kitware.com/21404 SystemInformation: Treat Solaris the same as Linux
> * http://review.source.kitware.com/21405 SystemTools: Fix FileExists for some SCO OpenServer file permissions
> 
> Once integrated there I can update CMake's copy.
> 
> I left out the "Use correct cmake macro." change because it is wrong.
> The SIZEOF_VOID_P macro is defined by code in CMakeLists.txt using
> the value of CMAKE_SIZEOF_VOID_P.  The former is a C++ preprocessor
> macro.  The latter is only visible in CMake code.

Thanks - I'll get rid fo the CMAKE_SIZEOF_VOID_P bit.

One thing: in the "Treat BSDs more uniformly" patch, there was some:

+# if defined(KWSYS_SYSTEMINFORMATION_HAS_BACKTRACE)
+#  include <execinfo.h>
+#  if defined(KWSYS_SYSTEMINFORMATION_HAS_CPP_DEMANGLE)
+#    include <cxxabi.h>
+#  endif
+#  if defined(KWSYS_SYSTEMINFORMATION_HAS_SYMBOL_LOOKUP)
+#    include <dlfcn.h>
+#  endif
+# endif

which I don't seem to see anymore - is that part superfluous?


Cheers,

Patrick