[cmake-developers] Automoc same source - More thoughts

Sebastian Holtermann seblist at xwmw.org
Thu Apr 14 04:22:47 EDT 2016


Am 13.04.2016 um 16:40 schrieb Brad King:
> On 04/13/2016 10:08 AM, Sebastian Holtermann wrote:
>> Well, looking into the sources and there is already Tests/QtAutogen.
>> It covers various #include "moc_..." cases.
>
> Perhaps, but as pointed out in the issue tracker entry I linked those
> test cases were not sufficient to fail after the the incorrect fix
> made and reverted there.  Please identify why and extend them.

Now after testing it I think the incorrect fix was not incorrect at all.
The feared moc renaming was only applied to mocs that were not #included.

For not #included mocs the (not so) incorrect pach creates long moc 
names in this format: moc_DIRNAME_BASENAME.cpp.

My patch creates the not #included mocs in subdirectories.
This is more robust IMO.

-Sebastian



More information about the cmake-developers mailing list