[cmake-developers] Automoc same source - More thoughts

Sebastian Holtermann seblist at xwmw.org
Wed Apr 13 10:08:13 EDT 2016


Am 12.04.2016 um 21:26 schrieb Brad King:
> On 04/12/2016 03:12 PM, Sebastian Holtermann wrote:
>> Here it is. Please review/commit.
>>
>> To test it insert #include "moc_item.cpp" in any or many
>> of the item.cpp files of the attached test project.
>
> Thanks for working on this!
>
> As requested in the issue tracker entry you linked,
> in this comment:
>
>    https://cmake.org/Bug/view.php?id=12873#c40513
>
> please extend the CMake test suite with a case covering
> this.  We need to test both the conflicting source name
> use case and the #include "moc_..." use case.  Please
> revise the patch to include such tests.
>

Thanks for the feedback.

Well, looking into the sources and there is already Tests/QtAutogen.
It covers various #include "moc_..." cases.
What is missing is a same-name case.
I will post an updated patch later.

Regards,
Sebastian



More information about the cmake-developers mailing list