[cmake-developers] [PATCH] [CMake 0015674]: Windows: Correctly determine Windows version

[Brad King]

On 09/10/2015 07:24 PM, Gilles Khouzam wrote:
> This patch fixes the issue where on Windows 8 and above, by
> default the system version returned is always Windows 8.
> 
> In order for GetVersionEx to work properly, a manifest must be
> embedded in the exe telling it to ignore the new behavior and
> give the proper version.

Thanks.  I've started by extracting the changes to GetVersionEx
calls.  Yesterday I reverted the recent RtlGetVersion change:

 Revert "Windows: Fix CMAKE_HOST_SYSTEM_VERSION on Windows >= 8.1"
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4c7744c8

I rebased your patch on that and applied the part that gets the
third version component:

 Windows: Set CMAKE_HOST_SYSTEM_VERSION with three components
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4734df5f

I also extracted the KWSys part of the change and applied it upstream:

 http://review.source.kitware.com/20180
 http://review.source.kitware.com/20181

Once those test cleanly they will be integrated into KWSys and then
updated in CMake.  Then I can rebase everything else on top of that.

Thanks,
-Brad