[cmake-developers] Improvements for GHS MULTI Generator

Geoffrey Viola Geoffrey.Viola at asirobots.com
Wed Sep 9 23:54:28 EDT 2015


> Please check that this breakdown is correct
Nice job. It is correct.

> For future changes please try to send them as patch series broken down like this.  (The only reason I did so much squashing of the original GHS support was because it was brand new.)
That's good to know


Geoffrey Viola
SOFTWARE ENGINEER
 asirobots.com



-----Original Message-----
From: Brad King [mailto:brad.king at kitware.com]
Sent: Wednesday, September 09, 2015 9:01 AM
To: Geoffrey Viola <Geoffrey.Viola at asirobots.com>
Cc: cmake-developers at cmake.org
Subject: Re: [cmake-developers] Improvements for GHS MULTI Generator

On 09/06/2015 01:43 AM, Geoffrey Viola wrote:
> Attached is a patch for some minor improvements for the GHS MULTI generator.

Thanks.  The commit message mentions a few different changes.  I tried to split the changes into individual commits:

 GHS: Find latest 'int' directory
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=63591b94

 GHS: Tell MULTI to delete .elf.ael file
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=fbe0de92

 GHS: Fix generated file path slashes and quoting for 6.1.6
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=04de9007

Please check that this breakdown is correct.  For future changes please try to send them as patch series broken down like this.  (The only reason I did so much squashing of the original GHS support was because it was brand new.)

Thanks,
-Brad
This message contains confidential information and is intended only for the recipient. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately if you have received this e-mail by mistake and delete this e-mail from your system. Finally, the recipient should check this email and any attachments for the presence of viruses. The company accepts no liability for any damage caused by any virus transmitted by this email.


More information about the cmake-developers mailing list