[cmake-developers] Generator expressions for install destination

[Robert Goulet]

Hi,

Here's the patch to add generator expressions to the install command DESTINATION option.
Let me know if that's good to go.

>@@ -216,6 +216,7 @@ void cmScriptGenerator::GenerateScriptActionsPerConfig(std::ostream& os,
>         i != this->ConfigurationTypes->end(); ++i)
>       {
>       const char* config = i->c_str();
>+      this->ConfigurationName = config;
>       if(this->GeneratesForConfig(config))
>         {
>         // Generate a per-configuration block.
>

>This should not be needed if things are factored correctly.

>Everything in that block already passes "config" through as a parameter.

None of the places where I use GetDestination, except in cmInstallTargetGenerator, receives a config in parameter. An ideally, the ConfigurationName member should not even exist, but that will force all places to pass the config as a parameter. Imho it's better to keep refactoring in a separate patch.

-Robert Goulet

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20150909/e82d825e/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: install-dest-genex.patch
Type: application/octet-stream
Size: 23885 bytes
Desc: install-dest-genex.patch
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20150909/e82d825e/attachment-0001.obj>