[cmake-developers] [PATCH] Fix a few issues in FindHDF5 module

Brad King brad.king at kitware.com
Wed Sep 2 11:16:34 EDT 2015


On 09/02/2015 11:07 AM, Tim Gallagher wrote:
> It looks like the 2nd commit you linked to does the same thing as
> my patch (add hdf5hl_fortran to the Fortran library list). 

Not quite.  It is:

> -    set( HDF5_Fortran_HL_LIBRARY_NAMES_INIT hdf5hl_fortran
> +    set( HDF5_Fortran_HL_LIBRARY_NAMES_INIT hdf5hl_fortran hdf5_hl

One can see hdf5hl_fortran was already in that list.

Your patch was:

> -    set( HDF5_Fortran_LIBRARY_NAMES_INIT hdf5_fortran ${HDF5_C_LIBRARY_NAMES_INIT} )
> +    set( HDF5_Fortran_LIBRARY_NAMES_INIT hdf5_fortran hdf5hl_fortran ${HDF5_C_LIBRARY_NAMES_INIT} )

which adds it to a different list, though perhaps the wrong one
since it is not for the _HL component.

-Brad



More information about the cmake-developers mailing list