[cmake-developers] [PATCH] Tests: Use a less strict regular expression to look for "SONAME".

Brad King brad.king at kitware.com
Tue Sep 1 08:57:51 EDT 2015


On 08/31/2015 06:25 PM, Raphael Kubo da Costa wrote:
> Commit 899458ab ("Tests: Cover NO_SONAME property for SHARED libraries")
> introduced a few new ExportImport tests, and the
> check_lib_{no}soname.cmake scripts that parse readelf(1)'s output.
> 
> Make the regular expression matching the SONAME line output by readelf
> less strict, as the output format varies across implementations

Thanks!  The changes look good, but perhaps more are needed.

The same regex appears in

 Tests/Plugin/check_mod_soname.cmake

and has for years.  I think that one should be updated too, but I
wonder why this problem has not been revealed in that test before.

Thanks,
-Brad



More information about the cmake-developers mailing list