[cmake-developers] Add command line options for deprecation message control

[Brad King]

On 11/04/2015 06:40 PM, Michael Scott wrote:
> Here is the patch with all, new, error related code removed and 
> including the relevant documentation changes.

Thanks.  Now this is getting down closer to a reviewable scale.
However, this will be much easier to review as a series of small
incremental self-contained changes.  The current patch contains

* Text updates in existing tests
* Change in role of deprecation warnings
* Change to default deprecation warning state
* Change to cache storage of warning states
* Change in internal data structures and diagnostic state tracking
* etc.

This is too much to follow in one patch.

See attached patches for some updates.  I split out a starting patch
as an example of incremental changes.  Now those hunks don't clutter
the larger changes.  Please split up the rest of the patch into a
series of steps like that.  It may involve some intermediate code
that is added in one patch and replaced in the next, but that is okay.
That makes it much easier to review and much easier to bisect problems
in the future.

I renamed some structures in the revised patches:

 WarningLevel => DiagLevel
 ignoreWarningLevels => force

On the actual logic changes, the role of DoSuppressDevWarnings appears
to have been replaced by checking DiagLevels[...].count().  However,
then this hunk:

> +  // turn on author, and in turn deprecated, warnings (only) by default
> +  this->DiagLevels["dev"] = DIAG_WARN;

increments the count by default instead of only when an explicit
option has been set.  Please revise accordingly based on the attached
state.

Thanks,
-Brad

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Tests-Revise-message-in-RunCMake.CommandLine-Wdev-ca.patch
Type: text/x-diff
Size: 2041 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20151106/23431efc/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-W-options-to-control-deprecation-and-author-warn.patch
Type: text/x-diff
Size: 27023 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20151106/23431efc/attachment-0003.patch>