[cmake-developers] [Review Request] Topic FindGTK2_GTK2_TARGETS

Brad King brad.king at kitware.com
Mon Nov 2 14:53:07 EST 2015


On 11/02/2015 06:45 AM, Daniele E. Domenichelli wrote:
> This patch changes the behaviour to fill the GTK2_LIBRARIES variable
> with the targets when GTK2_USE_IMPORTED_TARGETS  is enabled.

Yes, I think this would be expected when the option is on.

> Moreover it adds a GTK2_TARGETS variable that always contains all the imported
> targets.
> 
>  * FindGTK2: Use targets in GTK2_LIBRARIES if GTK2_USE_IMPORTED_TARGETS is ON
>    https://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=5f933bd

LGTM.  Please merge to 'next' for testing.

Thanks,
-Brad



More information about the cmake-developers mailing list