[cmake-developers] [PATCH v8 0/5] Add XCTest Bundle Support

[Brad King]

On 03/14/2015 03:03 PM, Gregor Jasny wrote:
> I changed it into a Find module and it looks much more polished
> now.

Great.

> I fully agree that modifying the testee is not something one would
> expect when adding a test for it. Therefore I reverted the rpath
> setting for Frameworks and replaced it with a DYLD environment
> variable when calling xctest. For the App Bundle I reverted your
> ENABLE_EXPORTS call and replaced it with Xcode specific settings
> for the XCODE generator and a linker flag for the Makefile generator.

Okay.

> +      target_link_libraries(${target}
> +        PRIVATE "-bundle_loader $<TARGET_FILE:${testee}>")

Please try using this in a CMake source/build tree each with spaces
in the path.  Quoting may need updating; perhaps:

  target_link_libraries(${target}
     PRIVATE -bundle_loader $<TARGET_FILE:${testee}>)

> Once you ACK the series I will create a topic branch and follow
> the developer instructions.

Please proceed.

Thanks,
-Brad