[cmake-developers] Compact dependency graph

[Brad King]

On 06/01/2015 06:20 PM, Richard Ulrich wrote:
> Using a callback I now feed the error information back.
> 
> Here's the latest change: 
> https://github.com/ulrichard/CMake/commit/adf1cf5184d5a13702a03a090c501f1a6d0e39f4
> 
> The following line is still commented out:
> this->Makefile->StoreMatches(re); 
> Is it important enough to add another callback?
> What are those matches used for?

That populates the CMAKE_MATCH_<GROUP> variables and is needed.

It may be easiest to have the helper class take an optional
cmMakefile* in its constructor.  If non-null, call StoreMatches.

In this code:

> +      const std::string currentRegexString(*itvIt);
> +      const std::string currentReplaceString(*++itvIt);

please validate that the list length is even so that this does not
dereference an end iterator.

Thanks,
-Brad