[cmake-developers] [PATCH] Extended Nsight Tegra support for CMake

[Mikhail Filimonov]

I've improved the patch according to the Brad's and Dmitry's comments - namely:
1. Improved the documentation for a few target properties.
2. Removed the explicit toolchain file for Nsight Tegra generator test.
3. Improved the generator heuristics  for NsightTegraProjectRevisionNumber attribute.

Thanks,
-Mikhail

-----Original Message-----
From: cmake-developers [mailto:cmake-developers-bounces at cmake.org] On Behalf Of Mikhail Filimonov
Sent: 9 июля 2015 г. 18:43
To: Brad King
Cc: cmake-developers at cmake.org
Subject: Re: [cmake-developers] [PATCH] Extended Nsight Tegra support for CMake

Thanks for your feedback, Brad

From: Brad King [mailto:brad.king at kitware.com]
Sent: 9 июля 2015 г. 18:02

>We'd like to keep testing the default behavior without an explicit toolchain file.  Also we need to be independent of the toolsets that happen to be available on the system where the test runs, so we >should avoid hard-coding a toolset name if possible.  Is this part of the patch needed to test everything else?  If so, please look at adding more test cases for the new combinations (which can just be >more builds of the same test source tree).

That's more like a demonstration sample that will show the developers how the various Nsight Tegra project properties could be defined via the various CMake properties even if not directly related to Android - i.e. C_STANDARD and CMAKE_GENERATOR_TOOLSET Currently where's no samples directory in CMake source tree - so I've slightly reworked the existing test case. Maybe you could propose a better way to deliver that sample?

Thanks,
-Mikhail 


-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ExtendedNsightTegraSupport2.patch
Type: application/octet-stream
Size: 35219 bytes
Desc: ExtendedNsightTegraSupport2.patch
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20150713/88baecbf/attachment-0001.obj>