[cmake-developers] [PATCH for bug 15253] Ninja: Pass only the flags relevant to the language.

Brad King brad.king at kitware.com
Thu Jan 29 15:37:45 EST 2015


On 01/29/2015 03:02 PM, Brian Smith wrote:
> Also, note that this bug was originally reported by "karlhungus" in
> the bug tracker, but your commit message says it was reported by me.
> It would be great if you could give "karlhungus" the credit for
> reporting the bug instead of me when you merge it into the trunk.

It was your trouble with DEP_FILE in constructing your patch that
lead to the commit.  I've changed it to generically reference the
issue tracker entry instead:

 Ninja: Use "deps = msvc" only for C and CXX (#15253)
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8a93d3ea

Thanks,
-Brad



More information about the cmake-developers mailing list